Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Streaming Mode #109

Open
choubacha opened this issue Apr 2, 2018 · 0 comments
Open

Implement Streaming Mode #109

choubacha opened this issue Apr 2, 2018 · 0 comments
Labels
enhancement New feature or request hard Will likely require extra work and complexity to finish spike Take some time to spike on this for a proof of concept

Comments

@choubacha
Copy link
Owner

choubacha commented Apr 2, 2018

The horizon SDK has a streaming mode:
https://www.stellar.org/developers/horizon/reference/responses.html#streaming

We should test and find out how this plays with the reqwest and hyper work with it. This is a different content type that we'd accept: Accept: text/event-stream and I believe we need to maintain an open connection for it.

I'm not familiar with how this will be handled by reqwest, in hyper it's likely to be handled in a Stream type.

The response coming back from the sync client will be a reader that stays open:

seanmonstar/reqwest#278 (comment)

Implementing a streaming mode may not be available for all endpoints but that doesn't mean we don't need to accept them.

@choubacha choubacha added enhancement New feature or request hard Will likely require extra work and complexity to finish spike Take some time to spike on this for a proof of concept labels Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hard Will likely require extra work and complexity to finish spike Take some time to spike on this for a proof of concept
Projects
None yet
Development

No branches or pull requests

1 participant