Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hovering over icons does not reveal icon purpose. #134

Open
hkier opened this issue Apr 10, 2024 · 4 comments · May be fixed by #135
Open

Hovering over icons does not reveal icon purpose. #134

hkier opened this issue Apr 10, 2024 · 4 comments · May be fixed by #135
Labels
Accessibility enhancement New feature or request good first issue Good for newcomers

Comments

@hkier
Copy link
Collaborator

hkier commented Apr 10, 2024

When the tooltip or cursor hovers over various icons on the page (web page not sure about mobile), a label does not appear showing the user the purpose of the icon. This is not a problem for common icons but but most website users will not be familiar with the GitHub nor ChiHackNight icons.
@hkier hkier added enhancement New feature or request good first issue Good for newcomers Accessibility labels Apr 10, 2024
@ma1hotraz
Copy link

ma1hotraz commented Apr 10, 2024 •
edited
Loading

@hkier I've addressed the issue and submitted a pull request. You can review the changes here:
https://github.com/chihacknight/ghost-buses-frontend/pull/135

@ma1hotraz ma1hotraz linked a pull request Apr 24, 2024 that will close this issue
Open
@ma1hotraz
Copy link

@hkier

@hkier
Copy link
Collaborator Author

hkier commented Apr 28, 2024

Sorry, I have been very busy with other matters (both personal and business). I did take a look at the Netlify deployment and it looks good. However, I wonder if the tooltip for Chi Hack Night should indicate the user will be taken to the Chi Hack Night website with by saying, "Chi Hack Night Website"

What ever you folks decide is fine with me.

@ma1hotraz
Copy link

@hkier No issue sir, I have changed the tooltip title for Chi Hack Night to Chi Hack Night Website.
Please let me know if anything else needs to be changed.

Sorry, I have been very busy with other matters (both personal and business). I did take a look at the Netlify deployment and it looks good. However, I wonder if the tooltip for Chi Hack Night should indicate the user will be taken to the Chi Hack Night website with by saying, "Chi Hack Night Website"

What ever you folks decide is fine with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accessibility enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhancement (134) - add tooltip labels for social icons on hover ma1hotraz/ghost-buses-frontend
2 participants
@hkier @ma1hotraz