Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix support for ParachainSystem AuthorizeUpgrade Hash #87

Open
crystalin opened this issue Nov 9, 2023 · 4 comments
Open

fix support for ParachainSystem AuthorizeUpgrade Hash #87

crystalin opened this issue Nov 9, 2023 · 4 comments

Comments

@crystalin
Copy link

The authorizeUpgrade signature has changed and is now taking an additional boolean "checkVersion" which makes the srtool hash not matching anymore.

I suggest adding "true" to the call hash https://github.com/chevdor/subwasm/blob/master/libs/substrate-runtime-proposal-hash/src/lib.rs#L68
@ntn-x2
Copy link
Contributor

ntn-x2 commented Mar 6, 2024

+1 for us! It seems this repo is not being maintained anymore?

@chevdor
Copy link
Owner

chevdor commented Mar 7, 2024

PRs are welcome :)

@ntn-x2 ntn-x2 mentioned this issue Mar 7, 2024
Closed
@ntn-x2
Copy link
Contributor

ntn-x2 commented Mar 7, 2024

Started a PR. Need to fix README and see if there's a better way to do it. I'll open it for review tomorrow.

@ntn-x2
Copy link
Contributor

ntn-x2 commented Mar 8, 2024

@chevdor PR is ready for review. It won't let me add you to the reviewer set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add flag for new check_version KILTprotocol/subwasm
3 participants
@crystalin @chevdor @ntn-x2