Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use requirements.txt as the definitive source of packages to install. #62

Open
dumol opened this issue Oct 3, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@dumol
Copy link
Contributor

dumol commented Oct 3, 2024

Through #58, we started using requirements.txt instead of safety for alerting us of security issues, leveraging GitHub's own security checks.

As suggested at #58 (comment), we could use it as the definitive source of packages to install, e.g.:

pip==24.2
psutil==6.0.0
pycparser==2.22
pywin32==306; sys_platform == 'windows'

This should work better than defining the packages to install through build.conf, then auto-updating requirements.txt with pip freeze, and then automatically commiting the update at the end of a successful Windows build.

@dumol dumol added the enhancement New feature or request label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant