Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support lists in plugin settings #85

Open
zAlweNy26 opened this issue Jul 18, 2024 · 2 comments
Open

[Feature] Support lists in plugin settings #85

zAlweNy26 opened this issue Jul 18, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@zAlweNy26
Copy link
Member

Is your feature request related to a problem? Please describe.
At the moment the lists are not supported in plugin settings, making it impossible to ask for an array of strings (for example).

Describe the solution you'd like
Support the lists json schema so that it can be used in plugin settings.

@zAlweNy26 zAlweNy26 added the enhancement New feature or request label Jul 18, 2024
@pieroit
Copy link
Member

pieroit commented Jul 19, 2024

@zAlweNy26 does this require changes core side?
It should be possible to have lists in pydantic models, also the JSON schema should reflect that

@zAlweNy26
Copy link
Member Author

No need for changes on core side, as Pydantic already support lists. The frontend just need to manage the generated json schema for lists.

@zAlweNy26 zAlweNy26 added the good first issue Good for newcomers label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants