Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bs4 with beautifulsoup4 #13

Closed
wants to merge 1 commit into from
Closed

Replace bs4 with beautifulsoup4 #13

wants to merge 1 commit into from

Conversation

fabaff
Copy link

@fabaff fabaff commented Sep 7, 2023

Distributions usually don't ship the bs4 dummy package.

@chemelli74
Copy link
Owner

Hi @fabaff , thx for the contribution.

while at it, please update the library import with:

from bs4 import BeautifulSoup

then update the api.py code accordingly.

Please install pre-commit hooks on your environment to assure everything is as expected.
Specifically for this PR you need to run poetry lock [--no-update]

Last but not least, you need to follow commitlint schema for commit messages.

Thanks,

Simone

P.S.> If you need further info, please join HomeAssistant on Discord and then contact me: chemelli74#2180

Simone

@fabaff
Copy link
Author

fabaff commented Sep 8, 2023

while at it, please update the library import with:
from bs4 import BeautifulSoup
then update the api.py code accordingly.

The module name and the name which is used to imported the module are two different things.

Last but not least, you need to follow commitlint schema for commit messages.

Sure

@chemelli74
Copy link
Owner

while at it, please update the library import with:
from bs4 import BeautifulSoup
then update the api.py code accordingly.

The module name and the name which is used to imported the module are two different things.

Indeed.
What I mean is to change code to:

from bs4 import BeautifulSoup
[...]
soup = BeautifulSoup(reply_text, "html.parser")

Simone

@chemelli74
Copy link
Owner

@fabaff are you going to finish this PR ?

Simone

@chemelli74
Copy link
Owner

Superseded by #33

@chemelli74 chemelli74 closed this Sep 20, 2023
@fabaff fabaff deleted the patch-1 branch September 20, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants