Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getUserByFirebaseId subscriptions #430

Open
5 tasks
eleanorreem opened this issue May 23, 2024 · 0 comments
Open
5 tasks

Refactor getUserByFirebaseId subscriptions #430

eleanorreem opened this issue May 23, 2024 · 0 comments
Labels
complexity: advanced Time needed to do this ticket will be large e.g. 2-3+ days help wanted Extra attention is needed maintenance Maintenance / chore work state: blocked Task is blocked.
Milestone

Comments

@eleanorreem
Copy link
Contributor

Overview

We want to start breaking up the GET /user/me request and only fetch information on the pages it is needed. This is starting with subscriptions. We created a new endpoint in this ticket to have a bespoke endpoint for getting subscriptions . The frontend migration is in this ticket and blocks this refactor. After the frontend has been migrated over, we can start breaking up the GetUserDto and remove subscriptions from the object.

Action Items

  • Remove leftJoins of subscription and subscription_user table from the database query in userService.getUserByFirebaseId.
  • This will impact the firebase module and therefore the rest of the site. There may be significant refactors ahead.
  • You will need to remove subscription_user and subscription imports from most modules as they will no longer be required.
  • Remove all instances of ISubscriptionUser. It should either be an entity or a dto.
  • Remove subscriptions property from the GetUserDto.
@eleanorreem eleanorreem added help wanted Extra attention is needed complexity: advanced Time needed to do this ticket will be large e.g. 2-3+ days state: blocked Task is blocked. maintenance Maintenance / chore work labels May 23, 2024
@kyleecodes kyleecodes added this to the 02. Roadmaps milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: advanced Time needed to do this ticket will be large e.g. 2-3+ days help wanted Extra attention is needed maintenance Maintenance / chore work state: blocked Task is blocked.
Projects
Status: To-Do Bloom Backend
Development

No branches or pull requests

2 participants