Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map menu text color is black instead of white #66

Open
bekuno opened this issue Mar 7, 2020 · 8 comments · May be fixed by #212
Open

Map menu text color is black instead of white #66

bekuno opened this issue Mar 7, 2020 · 8 comments · May be fixed by #212
Assignees
@RickyTUM
Labels
Bug Something isn't working Frontend Design User Interface problems

Comments

@bekuno
Copy link
Member

bekuno commented Mar 7, 2020

Describe the bug:

The map menu text color is black instead of white on Android 9.
This is nearly unreadable.
The text is white on Android 7.0.

To Reproduce:

Open the map view.
Open the menu.

Actual behavior/state after performing these steps:

20200307_120530

Expected behavior/state after performing these steps:

20200307_120437

Version of WhereYouGo used:

2020.03.05

Is the problem reproducible:
Yes
@bekuno bekuno added the Bug Something isn't working label Mar 7, 2020
bekuno pushed a commit to bekuno/cgeo-WhereYouGo that referenced this issue Mar 7, 2020
set text color for menus
e9d7f14 
fix cgeo#66

- remove theme definitions for api 11 an 14, merge them in the default configuration files (we are on min sdk 16)
- add text color definitions
- define the default text color (white) fo the AppTheme
@bekuno bekuno self-assigned this Mar 7, 2020
@bekuno bekuno mentioned this issue Mar 7, 2020
Closed
@Lineflyer
Copy link
Member

Can reproduce on Android 9. Fine however on older and newer versions (or it depends on resulution as my Android 9 device is a tablet).

@Lineflyer
Copy link
Member

Tested with PR#67:
Samsung S10, Android 10.

  • Menu color is fine (as it was also before)
  • White text is now also used in other places, where it should not be used (e.g. Caption of about page, Menu entries in map settings, Dir Chooser dialog). See attached screenshots for details.

Screenshot_20200308-112333
Screenshot_20200308-112347
Screenshot_20200308-112833
Screenshot_20200308-112257

@Lineflyer
Copy link
Member

Tested with PR #67:
Android 9, Samsung Galaxy Tab S4 (Tablet)

  • The problem of black menu text is still there
  • Additionally now white text in other parts, where it should not be (same as on Android 10 as posted above).
    Screenshot_20200308-112603
    Screenshot_20200308-112556
    Screenshot_20200308-112648

@bekuno
Copy link
Member Author

bekuno commented Mar 8, 2020

Yes, I saw it in the same way on older Android versions.
The formatting needs to be completely recreated.
We should let it for now unchanged.

@bekuno bekuno removed their assignment Mar 8, 2020
@Lineflyer
Copy link
Member

I had a brief look on older Android versions:
Basically the same. The menu text mentioned in your inital post is unchanged, but other parts, which should not have white text, got white text.

I agree. Lets leave PR#67 out for now and come back to this problem a bit later. Its mainly cosmetic and the whole thing needs rework.

@Lineflyer Lineflyer added the Frontend Design User Interface problems label Mar 8, 2020
@andrixnet
Copy link

I've just joined the WhereYouGo beta testers :-)
Thank you for reviving this app.

I can confirm this issue on Samsung S9+ / Android 9

@RickyTUM
Copy link

When I make the following change to the file:
src/main/res/values/styles_theme.xml
the menu looks good on Android 7 and 9.

<style name="AppTheme" parent="@android:style/Theme.Light.NoTitleBar">

change to:

<style name="AppTheme" parent="android:Theme.DeviceDefault.Dialog.NoActionBar">

@bekuno
Copy link
Member Author

bekuno commented Aug 30, 2020

@RickyTUM
Thanks for finding a possible solution.
Please create a PR, if possible.
If you have any questions, take a look at the c:geo wiki (adopt it for WhereYouGo) and do not hesitate to ask them.

@RickyTUM RickyTUM linked a pull request Sep 1, 2020 that will close this issue
Open
@bekuno bekuno linked a pull request Sep 21, 2020 that will close this issue
Update styles_theme.xml #212
Open
@bekuno bekuno mentioned this issue Apr 27, 2021
Closed
@bekuno bekuno mentioned this issue May 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RickyTUM RickyTUM

Labels
Bug Something isn't working Frontend Design User Interface problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update styles_theme.xml RickyTUM/WhereYouGo
4 participants
@Lineflyer @andrixnet @bekuno @RickyTUM