Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Fully's MQTT API #7

Open
cgarwood opened this issue Oct 20, 2020 · 3 comments
Open

Add support for Fully's MQTT API #7

cgarwood opened this issue Oct 20, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@cgarwood
Copy link
Owner

Fully Kiosk Browser can connect to an MQTT server and will publish its full device information every 60 seconds (same info we get from the REST API). It will also publish a variety of events on the MQTT server as they happen (motion detection, ac adapter plugged/unplugged, screensaver start/stop, device movement, etc). We should add MQTT support to this lib alongside the REST API support so we can add triggers based on events.

@cgarwood cgarwood added the enhancement New feature or request label Oct 20, 2020
@crowbarz
Copy link

One major advantage of supporting MQTT is that the MQTT connection does not require the device's IP address to be hardcoded in config, rather the MQTT server's IP address is hardcoded on the device running Fully. If the device can connect to the network via multiple different network interfaces, eg. Ethernet or WiFi, chances are that each of the interfaces will have a different IP address, so being only able to specify a single IP address for a device in this library's associated HA integration would also prevent the device from being reachable if its primary network interface happens to be unavailable and it has failed over to another network interface.

So ideally, the MQTT integration would pick up the device's current IP address via the MQTT device update and use that to talk to Fully's REST interface, rather than having to specify the device's IP address manually when setting up the HA integration.

@Sholofly
Copy link

Sholofly commented Feb 8, 2022

@cgarwood is there a way to contribute to this feature?

Sholofly added a commit to Sholofly/python-fullykiosk that referenced this issue Feb 12, 2022
Sholofly added a commit to Sholofly/python-fullykiosk that referenced this issue Feb 12, 2022
@Sholofly
Copy link

@cgarwood Can you review and, if possible, complete my PR on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants