Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonise some canonical units #238

Open
larsbarring opened this issue Nov 18, 2024 · 2 comments
Open

Harmonise some canonical units #238

larsbarring opened this issue Nov 18, 2024 · 2 comments
Labels
accepted Agreed for inclusion in the next release of the standard name table or other controlled vocabulary standard name (added by template) Requests and discussions for standard names and other controlled vocabulary

Comments

@larsbarring
Copy link

I just saw that for some of the standard names the canonical units use division / notation rather than "inversion -1 notation". Is there a specific reason for this? Else it might be useful to change to the latter.

Here is a table of the ones I have found:

Standard Name Canonical Units
downwelling_longwave_flux_in_air_assuming_clear_sky_and_reference_mole_fraction_of_ozone_in_air W/m2
downwelling_longwave_flux_in_air_assuming_reference_mole_fraction_of_ozone_in_air W/m2
downwelling_shortwave_flux_in_air_assuming_clear_sky_and_reference_mole_fraction_of_ozone_in_air W/m2
downwelling_shortwave_flux_in_air_assuming_reference_mole_fraction_of_ozone_in_air W/m2
reference_mole_fraction_of_ozone_in_air mol/mol
surface_downwelling_longwave_flux_in_air_assuming_clear_sky_and_reference_mole_fraction_of_ozone_in_air W/m2
surface_downwelling_longwave_flux_in_air_assuming_reference_mole_fraction_of_ozone_in_air W/m2
surface_downwelling_shortwave_flux_in_air_assuming_clear_sky_and_reference_mole_fraction_of_ozone_in_air W/m2
surface_downwelling_shortwave_flux_in_air_assuming_reference_mole_fraction_of_ozone_in_air W/m2
surface_upwelling_longwave_flux_in_air_assuming_clear_sky_and_reference_mole_fraction_of_ozone_in_air W/m2
surface_upwelling_longwave_flux_in_air_assuming_reference_mole_fraction_of_ozone_in_air W/m2
surface_upwelling_shortwave_flux_in_air_assuming_clear_sky_and_reference_mole_fraction_of_ozone_in_air W/m2
surface_upwelling_shortwave_flux_in_air_assuming_reference_mole_fraction_of_ozone_in_air W/m2
toa_outgoing_longwave_flux_assuming_clear_sky_and_reference_mole_fraction_of_ozone_in_air W/m2
toa_outgoing_longwave_flux_assuming_reference_mole_fraction_of_ozone_in_air W/m2
toa_outgoing_shortwave_flux_assuming_clear_sky_and_reference_mole_fraction_of_ozone_in_air W/m2
toa_outgoing_shortwave_flux_assuming_reference_mole_fraction_of_ozone_in_air W/m2
upwelling_longwave_flux_in_air_assuming_clear_sky_and_reference_mole_fraction_of_ozone_in_air W/m2
upwelling_longwave_flux_in_air_assuming_reference_mole_fraction_of_ozone_in_air W/m2
upwelling_shortwave_flux_in_air_assuming_clear_sky_and_reference_mole_fraction_of_ozone_in_air W/m2
upwelling_shortwave_flux_in_air_assuming_reference_mole_fraction_of_ozone_in_air W/m2

Moreover, I also found two more that use the full unit string radian rather rad, which is used elsewhere in the table. Same here, if there is not specific reason for this, I suggest changing these too.

Standard Name Canonical Units
projection_x_angular_coordinate radian
projection_y_angular_coordinate radian

Kind regards,
Lars

@larsbarring larsbarring added add to cfeditor (added by template) Moderators are requested to add this proposal to the CF editor standard name (added by template) Requests and discussions for standard names and other controlled vocabulary labels Nov 18, 2024
Copy link

Thank you for your proposal. These terms will be added to the cfeditor (http://cfeditor.ceda.ac.uk/proposals/1) shortly. Your proposal will then be reviewed and commented on by the community and Standard Names moderator.

@efisher008 efisher008 removed the add to cfeditor (added by template) Moderators are requested to add this proposal to the CF editor label Nov 22, 2024
@efisher008
Copy link
Collaborator

Thank you for pointing this out Lars. This appears to have been an error, and all 21 names have been changed to express their units with inverse -1 notation.

projection_x_angular_coordinate and projection_y_angular_coordinate have had their units changed from radian to rad, which is now compliant with the P06 terms.

I have marked these as accepted as the only change necessary was to the unit notation. These changes should be published in the next release of the Standard Name table (v88), which is expected in December 2024/January 2025.

@efisher008 efisher008 added the accepted Agreed for inclusion in the next release of the standard name table or other controlled vocabulary label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Agreed for inclusion in the next release of the standard name table or other controlled vocabulary standard name (added by template) Requests and discussions for standard names and other controlled vocabulary
Projects
None yet
Development

No branches or pull requests

2 participants