Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing links in wiki page cited in Appendix F #537

Open
KCANNIZZARO opened this issue Sep 1, 2024 · 8 comments · May be fixed by #563 or cf-convention/cf-convention.github.io#554
Open

missing links in wiki page cited in Appendix F #537

KCANNIZZARO opened this issue Sep 1, 2024 · 8 comments · May be fixed by #563 or cf-convention/cf-convention.github.io#554
Labels
CF1.12? We might conclude this issue in time for CF1.12 defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors new contributor This issue was worked on by new contributors to the CF conventions

Comments

@KCANNIZZARO
Copy link

KCANNIZZARO commented Sep 1, 2024

ON THE PAGE ENTITLED Mapping from CF Grid Mapping Attributes to CRS WKT Elements THERE IS A LINK TO A WEBSITE CALLED REMOTESENSING.ORG, BUT WHEN YOU CLICK ON IT, NO SITE HAS BEEN PUBLISHED TO THAT DOMAIN

@JonathanGregory
Copy link
Contributor

@KCANNIZZARO, thanks for your help. Do you mean on the page https://cfconventions.org/wkt-proj-4.html, or some other page? Please could you say where in the page concerned you find this missing link, because I can't find it, and our regular link-checker program hasn't detected it.

@JonathanGregory JonathanGregory added the defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors label Sep 2, 2024
@larsbarring
Copy link
Contributor

larsbarring commented Sep 2, 2024

In Table F.1 (in Appendix F) of the Conventions document there are several links to this wiki page, which was last edited in early 2017 and contains links to remotesensing.org (there are other stale links in this page).

@JonathanGregory
Copy link
Contributor

Thanks, @larsbarring. I think https://cfconventions.org/wkt-proj-4.html, which is linked to the CF website, is an updated version of https://github.com/cf-convention/cf-conventions/wiki/Mapping-from-CF-Grid-Mapping-Attributes-to-CRS-WKT-Elements. The former doesn't have missing links, I believe, since the web link-checker would find them if it did. If that's right, we should update Appendix F.

@JonathanGregory JonathanGregory changed the title NO WEBSITE missing links in wiki page cited in Appendix F Sep 2, 2024
@larsbarring
Copy link
Contributor

Yes, I agree that Appendix F needs to be updated. We also have #479 that preferably should be dealt with at the same time. And there are a couple of other improvements that are overdue. I have for a long time meant to do something about this, but it has not yet happened.

@JonathanGregory JonathanGregory added the new contributor This issue was worked on by new contributors to the CF conventions label Sep 3, 2024
@JonathanGregory JonathanGregory added the CF1.12? We might conclude this issue in time for CF1.12 label Oct 20, 2024
@JonathanGregory JonathanGregory linked a pull request Nov 6, 2024 that will close this issue
@JonathanGregory JonathanGregory linked a pull request Nov 6, 2024 that will close this issue
@JonathanGregory
Copy link
Contributor

I have created #563 to remedy this defect, by replacing the references to the wiki page with references to the updated Mapping from CF Grid Mapping Attributes to CRS WKT Elements, which doesn't contain the broken links.

Since this is a defect issue, the change will be accepted if no-one raises concerns within three weeks (27th Nov).

@larsbarring
Copy link
Contributor

I added a couple of comments in the PR regarding files missing in the referred wiki page.

@JonathanGregory
Copy link
Contributor

Thanks, @larsbarring. The file ellipsoid.csv and the other two csv files are attachments to the GitHub wiki page. They were intended to be linked at the bottom of the CF-WKT page, which itself is linked from Appendix F, but they appear there as now-defunct URLs to the old trac wiki instead. Whoops.

I have therefore prepared a website PR to correct the links in my modified version of the CF-WKT webpage, so that they point to the versions in the GitHub wiki. These links now appear after Table 2 in the webpage, which is where they're relevant. Noticing that the webpage was quite out-of-date, I've brought Tables 1 and 2 up to date and made them compatible with GitHub markdown so their contents are displayed properly.

I have modified the conventions PR #563 to say more precisely where the information can be found e.g. for the reference_ellipsoid_name, "Valid names are given in ellipsoid.csv, following Table 2 in CF-WKT."

I hope this is all OK.

@larsbarring
Copy link
Contributor

Thanks Jonathan @JonathanGregory !

This looks all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CF1.12? We might conclude this issue in time for CF1.12 defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors new contributor This issue was worked on by new contributors to the CF conventions
Projects
None yet
3 participants