Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: Tag debug shapes #593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

debug: Tag debug shapes #593

wants to merge 1 commit into from

Conversation

johannes-wolf
Copy link
Member

@johannes-wolf johannes-wolf commented May 17, 2024

Tag debug paths as such and skip them in merge-path.

Debug shapes bring other problems, maybe we should remove the feature or remove documentation about it.

Fixes #575

@johannes-wolf johannes-wolf added the bug 🐛 Something isn't working label May 17, 2024
@fenjalien
Copy link
Member

This is would also resolve #463 if you used the ignore key instead

@johannes-wolf
Copy link
Member Author

johannes-wolf commented May 18, 2024

They are different. Marks must be considered for bbox calculation and intersection (?), debug shapes not. Although, this is not yet implemented in this PR.

@fenjalien
Copy link
Member

I don't think marks should be considered for intersections and would they be big enough to really count towards a bounding box?

Besides that, if we do have separate keys for debug, marks, hidden and ignore, would there be a way to combine them into one field? Maybe a "type" or "class" key that holds "debug" or "mark", it could even be an array to hold multiple if needed. It could even be a bytefield...
We'll be needing something similar for modifiers anyway.

@johannes-wolf
Copy link
Member Author

johannes-wolf commented May 19, 2024

I don't think marks should be considered for intersections and would they be big enough to really count towards a bounding box?

Besides that, if we do have separate keys for debug, marks, hidden and ignore, would there be a way to combine them into one field? Maybe a "type" or "class" key that holds "debug" or "mark", it could even be an array to hold multiple if needed. It could even be a bytefield... We'll be needing something similar for modifiers anyway.

Yes, I think some kind of "class" is good. We could then provide a function for filtering out certain elements.
Maybe just a tags list of strings/ints?

@fenjalien
Copy link
Member

If we are still aiming for modifiers in 0.3.0, can this be blocked until modifiers are implemented? Then we can use whatever system works for modifiers.

@johannes-wolf
Copy link
Member Author

johannes-wolf commented May 21, 2024

If we are still aiming for modifiers in 0.3.0, can this be blocked until modifiers are implemented? Then we can use whatever system works for modifiers.

Yes. Although path-replacing modifiers need no special handling, as they just replace the original path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked 🚧 bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

canvas debug inverts fill area of merge-path
2 participants