Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: main footer #44

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: main footer #44

wants to merge 14 commits into from

Conversation

AfonsoMartins26
Copy link
Contributor

No description provided.

@AfonsoMartins26 AfonsoMartins26 linked an issue Oct 19, 2024 that may be closed by this pull request
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for cesium-hydrogen-new ready!

Name Link
🔨 Latest commit 33f4e3b
🔍 Latest deploy log https://app.netlify.com/sites/cesium-hydrogen-new/deploys/6748b466bd9244000829400d
😎 Deploy Preview https://deploy-preview-44--cesium-hydrogen-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/components/footer.tsx Outdated Show resolved Hide resolved
src/components/footer.tsx Show resolved Hide resolved
src/components/footer.tsx Show resolved Hide resolved
src/components/footer.tsx Outdated Show resolved Hide resolved
src/components/footer.tsx Outdated Show resolved Hide resolved
src/components/footer.tsx Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@AfonsoMartins26 AfonsoMartins26 marked this pull request as ready for review November 23, 2024 19:37
Copy link
Contributor Author

@AfonsoMartins26 AfonsoMartins26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀 !

src/components/footer.tsx Outdated Show resolved Hide resolved
@diogogmatos
Copy link
Member

Make sure to merge the main branch with this one (from the current branch, run: git merge main) to get the changes regarding internationalization, since they change a lot including the main page and layout paths (app/page.tsx/app/layout.tsx -> app/[lang]/page.tsx/app/[lang]/layout.tsx).

Also don't forget to include the Footer component in the layout of the app instead of "page.tsx" ;)

@diogogmatos
Copy link
Member

diogogmatos commented Nov 27, 2024

Please update the image paths to use these ones (they were introduced in the navbar PR). 🙏🏼 Maybe we'll need to transform them into components so we can pass a "fill" color, since the color of the social media icons is slightly different in the navbar and in the footer.

image

@diogogmatos
Copy link
Member

diogogmatos commented Nov 27, 2024

I think this margin (yellow bar) is not supposed to be here 🤔

image

Removing that "mt-8" should fix it ;)

@RicoPleasure
Copy link

It may have some way to do what I did with the svg's in different components. However, I think this way is very pleasant. Let me know how you prefer it. Thanks!

public/icons/icon_social.tsx Outdated Show resolved Hide resolved
public/icons/icon_social.tsx Outdated Show resolved Hide resolved
src/components/footer.tsx Outdated Show resolved Hide resolved
src/components/footer.tsx Outdated Show resolved Hide resolved
src/components/footer.tsx Outdated Show resolved Hide resolved
src/components/footer.tsx Outdated Show resolved Hide resolved
src/components/footer.tsx Outdated Show resolved Hide resolved
src/components/footer.tsx Outdated Show resolved Hide resolved
src/components/footer.tsx Outdated Show resolved Hide resolved
src/components/footer.tsx Outdated Show resolved Hide resolved
diogogmatos
diogogmatos previously approved these changes Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

feat: main footer
4 participants