Next issues

[cpq]

• Header files should have CPP header guards so functions can be called from CPP - mongoose_glue.h specifically should have this
• Maybe mongoose_config.h should specify a value for MG_ENABLE_POSIX_FS now that it is used in the user code?
• In mongoose_glue.c, glue_file_open_xxx() wraps fopen() with #if MG_ENABLE_POSIX_FS, but glue_file_write_xxx() and glue_file_close_xxx() do not wrap the posix calls. This should be consistent. eg

#if MG_ENABLE_POSIX_FS
  return fclose(fp) == 0;
#else
  return true;
#endif

and

#if MG_ENABLE_POSIX_FS
  return fwrite(buf, 1, len, fp) == len;
#else
  return true;
#endif

• mongoose_glue.c should use explicit casts to cast pointers to permit unmodified compilation as cpp if required (eg. if hal.h or equivalent uses cpp functionality such as classes).
  Noted in glue_file_open_xxx(), glue_file_write_xxx() and glue_file_close_xxx() casting fp (void*) to (FILE*)
• Possibly not an issue, but: When an ota variable is created in the wizard, the mg_ota_xxx() functions must be created for the project to compile. On the ESP32 platform (and possible others where MG_OTA_CUSTOM is set?) these functions do not exist. It would be a convenience if stubbed out copies of these functions were placed in main.c (or glue?) to allow the project to build. Alternatively, setting MG_OTA_NONE instead of MG_OTA_CUSTOM would achieve this and prevent the compilation failure, leaving it to the user to implement the mg_ota_xxx() functions.
• In mongoose_impl.c, mqtt_event_handler() prints a closing message MG_DEBUG(("%lu Closing")); with no supplied parameter. This should have a parameter as follows: MG_DEBUG(("%lu Closing", c->id));
• Generating (or subscribing to?) the mqtt rx topic crashes the application with a corrupted backtrace if the rx topic contains an variable whose value is not empty. To duplicate: Enable MQTT in the wizard and build the default project. Optionally adjust the device_id default value to be an empty string to observe a successful connection instead. Observed on ESP32. #7
• When an action/button is placed on a panel which has a save button, clicking the 'save' button triggers the action. I believe the button should only be triggered if it is clicked or otherwise explicitly activated. #6
• When a file is uploaded using the upload type, once the file finishes uploading, the file being written to is not closed until the socket times out. I believe mongoose_impl.c should set the 'is_draining' parameter once the upload is complete to immediately close the socket and file, as shown below #8

  // Catch uploaded file data for both MG_EV_READ and MG_EV_HTTP_HDRS
  if (us->marker == 'U' && (ev == MG_EV_HTTP_HDRS || ev == MG_EV_READ) &&
      us->expected > 0 && c->recv.len > 0) {
    bool ok = us->fn_write(us->fp, c->recv.buf, c->recv.len);
    us->received += c->recv.len;
    MG_DEBUG(("%lu chunk: %lu bytes, %lu so far, %lu total, ok: %d", c->id,
              c->recv.len, us->received, us->expected, ok));
    c->recv.len = 0;  // Delete received data
    if (ok == false) {
      mg_http_reply(c, 400, "", "Upload error\n");
      c->is_draining = 1;  // Close connection when response it sent
    } else if (us->received >= us->expected) {
      // Uploaded everything. Send response back
      MG_INFO(("%lu done, %lu bytes", c->id, us->received));
      mg_http_reply(c, 200, NULL, "%lu ok\n", us->received);
      c->is_draining = 1;  // Close connection when response is sent <<< ADD THIS LINE
    }
  }

• Uploading a file to a file variable endpoint when not authenticated causes the application to crash in mongoose_impl.c handle_uploads(). To duplicate: create and place a file variable with a write auth level of 1, log in to the dashboard as user, restart the mongoose application, then try to upload a file using the (invalidated) user session open in the browser. #9
• A callback to create/initialise the mqtt semaphore should possibly be added. In many RTOSes, a semaphore must be created/initialised at runtime before it can be used. A glue_lock_create() function in mongoose_glue.c and called early in mongoose_impl.c mongoose_init() would probably do (though initialising the semaphore earlier in the runtime might be wiser, in which case it would need to be a user problem after all... having a glue_lock_create() function would still be good though) #10
• Dropdowns are completely broken in the current wizard release. When adding a dropdown variable to a panel, the 'list' variables are unavailable to select to populate the dropdown. This can be observed on the default web UI builder panel, Settings > Log Level variable. #11
• Toggles in panels with a 'save' button don't send a POST to the server (either when clicked, or when save is clicked). Expected behaviour: State of a toggle is sent when 'save' is clicked. #12
• Feature request (low importance): If there are pages with an authorization level of 0 eg. the dashboard, they should be accessible without login. (I can get by without this). #13

[cpq]

mg_ota functions: those are user-defined, and generated project must ensure that they exist. Either dummy, or built-in, or generated. In case of ESP32, mongoose_config should set #define MG_OTA MG_OTA_ESP32 - a mongoose built-in support.

[cpq]

"Generating (or subscribing to?) the mqtt rx" - cannot reproduce that. If I just enable MQTT in a default config, works fine (uses non-empty device_id expansion). If I use a non-existent variable, works too. Let me know the way to reproduce, please!