Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard file upload not terminating #23

Closed
dvosully opened this issue Jun 4, 2024 · 2 comments
Closed

Wizard file upload not terminating #23

dvosully opened this issue Jun 4, 2024 · 2 comments
Assignees

Comments

@dvosully
Copy link

dvosully commented Jun 4, 2024

A recent update to add an alignment to file writes has meant file uploads may not complete successfully.
Identified when trying to do an OTA firmware update which never completed, tracing revealed that in handle_uploads() the us->received never reached the us->expected when the file finished transmission, and the close_uploaded_file() callback was never executed.
Changing the alignment variable to 1 instead of 32 has stopped this fault from manifesting for me, but obviously that removes the point of the alignment for targets that require it.

@cpq cpq self-assigned this Jul 2, 2024
@cpq
Copy link
Member

cpq commented Jul 3, 2024

Fixed, please verify!

Note that the new wizard is pushed.
The old wizard is accessible at https://mongoose.ws/wizard1/ - we'll keep that URL for some transition time

@dvosully
Copy link
Author

I can confirm that this is no longer happening for me using the new wizard.

The old wizard is giving auth failure for data points when I log in currently, the changes there are quite substantial so I haven't investigated or tested with the old wizard.

@cpq cpq closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants