Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve custom file handling #19

Closed
cpq opened this issue May 17, 2024 · 2 comments
Closed

Improve custom file handling #19

cpq opened this issue May 17, 2024 · 2 comments
Assignees

Comments

@cpq
Copy link
Member

cpq commented May 17, 2024

I have added a file containing a list of CA certificates in mongoose_fs.c to make it easier to handle TLS connections without requiring the specific CA cert be provided, and without needing to embed it in mongoose_glue.h.
I have added a /web_root/logo.svg file to mongoose_fs.c to allow the browser to display a browser tab icon (like favicon.ico) (though on reflection I wonder if I could achieve that with css in the page properties? I'm sufficiently unfamiliar with how that all works to guess).

CA file for MQTT server, cert/key files for MQTT two-way auth, browser logo.

@dvosully should we display the logo set in the web ui editor as browser logo as well?

@cpq cpq self-assigned this May 17, 2024
@dvosully
Copy link

@cpq Using the web ui editor logo as the browser logo would be a good start, but I think they may be different. The browser logo is rendered pretty small (in my case using the whole logo there is so small as to be entirely indistinguishable) but a smaller simpler logo (in my case an extract of the main logo) makes a good browser logo.

Regarding cert/key files for MQTT two-way auth, I would be keen for the API to maintain some way for user code to supply these if required, rather than embedding them into mongoose_fs.c and mongoose_impl.c - that would be problematic for any application where these get generated and loaded into the device by the end user. I'll supply details on that in a more relevant issue.

CA file is a bit different, because a generic list of CA certs can cover most public servers pretty easily.

@cpq
Copy link
Member Author

cpq commented Jul 17, 2024

Added UI logo uploading.
TLS certs will be handled as a separate effort, since TLS is a somewhat different beast.

@cpq cpq closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants