Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flakey Tests in pull-cert-manager-approver-policy-test #559

Open
erikgb opened this issue Dec 29, 2024 · 0 comments
Open

Flakey Tests in pull-cert-manager-approver-policy-test #559

erikgb opened this issue Dec 29, 2024 · 0 comments

Comments

@erikgb
Copy link
Contributor

erikgb commented Dec 29, 2024

{Failed after 0.017s.
expected the condition to maintain not-ready
Expected
    <bool>: true
to be false failed [FAILED] Failed after 0.017s.
expected the condition to maintain not-ready
Expected
    <bool>: true
to be false
In [It] at: /home/prow/go/src/github.com/cert-manager/approver-policy/pkg/internal/controllers/test/ready.go:364 @ 12/29/24 13:46:05.752
}

https://prow.infra.cert-manager.io/view/gs/cert-manager-prow-artifacts/pr-logs/pull/cert-manager_approver-policy/558/pull-cert-manager-approver-policy-test/1873364248227221504

I looked at the failing test, and the test setup is very advanced. I would suggest to simplify to fix this flake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant