Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

remove network prop on CeloProvider #246

Open
aaronmgdr opened this issue Jun 1, 2022 · 0 comments
Open

remove network prop on CeloProvider #246

aaronmgdr opened this issue Jun 1, 2022 · 0 comments
Assignees
Labels

Comments

@aaronmgdr
Copy link
Member

Rather than passing in an entire Network Object instead just pass in the chainID of the default network (alternatively the network name)

Currently when network is passed the object isn't actually used instead it finds a network in the networks array which matches the name. This is confusing as someone could pass in a network with a different RPC url and then have it not actually used

@aaronmgdr aaronmgdr added the 5.0 label Jun 1, 2022
@aaronmgdr aaronmgdr changed the title Change replace network prop with chainID prop on provider Change replace network prop with chainID prop on CeloProvider Jun 1, 2022
@aaronmgdr aaronmgdr changed the title Change replace network prop with chainID prop on CeloProvider remove network prop on CeloProvider Jun 14, 2022
@aaronmgdr aaronmgdr self-assigned this Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant