Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a function that returns returns tape name and object store name #94

Open
nmassey001 opened this issue Feb 28, 2024 · 1 comment
Open
Assignees

Comments

@nmassey001
Copy link
Contributor

Currently the code "munges" the name of the file to get the tape path and object store path in multiple places.
It would be much better if we could write a function that does this munging so there is no chance of making a mistake in the code.

e.g.:

          holding_tape_path = (f"root://{tape_server}/{tape_base_dir}/"
                                 f"{holding_slug}")
          full_tape_path = (f"{holding_tape_path}/{tar_filename}")

and:

            bucket_name, object_name = (
                   path_details.object_name.split(':')
            )

and even worse in the delete code router (my doing)!

@nmassey001 nmassey001 self-assigned this May 16, 2024
@nmassey001
Copy link
Contributor Author

nmassey001 commented Jun 17, 2024

  • object name function
  • tape name function
  • use in put_transfer
  • use in get_transfer
  • use in del_transfer
  • use in archive_put
  • use in archive_get

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Refactor backlog
Development

No branches or pull requests

1 participant