Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

[wpr-go] Incorrect order of responses for requests with the same url #4645

Open
ulan opened this issue Sep 6, 2019 · 1 comment
Open

[wpr-go] Incorrect order of responses for requests with the same url #4645

ulan opened this issue Sep 6, 2019 · 1 comment

Comments

@ulan
Copy link
Contributor

ulan commented Sep 6, 2019

WPR seems to mix up the order of responses in findBestMatchInArchivedRequestSet.

Steps to reproduce:

  • cd $CHROMIUM_SRC
  • git cl patch 1761597
  • Live run: ./tools/perf/run_benchmark run v8.browsing_desktop --browser=system --output-format=html --story-filter='browse:tools:sheets' --show-stdout --pageset-repeat=1 --use-live-sites
  • Record: ./tools/perf/record_wpr '--story-filter=^browse\:tools\:sheets\:2019$' --browser=system desktop_system_health_story_set
  • Replay: ./tools/perf/run_benchmark run v8.browsing_desktop --browser=system --output-format=html --story-filter='browse:tools:sheets' --show-stdout --pageset-repeat=1

Expected: The replay runs without errors.
Actual: The web page shows "Error: Class$obf_1001: removeSent called when not waiting for ack"

Note that the live run may fail in future if the web page changes. Let me know if that happens and I'll adjust the JS code in the CL.

@CalebRouleau
Copy link
Contributor

Thanks for filing this!

Moved to https://bugs.chromium.org/p/chromium/issues/detail?id=1001658

We don't use the github issue tracker anymore since it is easier to stay aligned with chromium development if we use the Monorail issue tracker.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants