Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable generate_dummy_segmentation_extractor to generate voxel masks #213

Open
h-mayorquin opened this issue Sep 15, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@h-mayorquin
Copy link
Collaborator

We should add the capability for the dummy segmentation extractor to generate voxel masks. Problem right now is that SegmentationExtractor is based on image masks as get_roi_pixel_masks assumes that _image_masks exists already:

return _pixel_mask_extractor(self.get_roi_image_masks(roi_ids=roi_ids), roi_ids)

We should probably modify this so get_roi_pixel_masks first tries to call _pixel_masks before doing trying to get them from _image_masks.. This is important in its own right as it will allow us to have segmentation extractors that can return pixel masks without us requiring to define image_masks as a workaround. Moreover, we will be able to add a flag to generate_dummy_segmentation_extractor and just build a pixel_masks with voxel_mask or pixel_mask qualities over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant