Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SubImaging, SubSegmentation, MultiImaging and MultiSegmentation extractors #11

Closed
alejoe91 opened this issue Aug 13, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@alejoe91
Copy link
Contributor

@bendichter @Saksham20
I think that next we have to implement these Extractors:

  • SubImagingExtractor: returns a new extractor either cropped in xy or in time
  • SubSegmentationExtractor: returns only ROI in a certain square (crops in space)
  • MultiImaging and MutiSegmentation --> to handle multiple planes

I think we can use the SI implementations as a reference :)

@alejoe91 alejoe91 added the enhancement New feature or request label Aug 13, 2020
@alejoe91 alejoe91 self-assigned this Aug 13, 2020
@bendichter
Copy link
Contributor

bendichter commented Aug 13, 2020

For SubExtractors, sometimes boundaries are not straight. This is supported by e.g. calciumImagingAnalysis here. Do we want to support that?

@alejoe91
Copy link
Contributor Author

We could for the SegmentationExtractor, but not for the Imaging as retrieving frames and video assumes a rectangular shape

@bendichter
Copy link
Contributor

ok, makes sense

@CodyCBakerPhD
Copy link
Member

All tasks now completed as of #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants