From 29c3491913f4be558a950262fd854a445a6b2621 Mon Sep 17 00:00:00 2001
From: Paul Adkisson <paul.wesley.adkisson@gmail.com>
Date: Tue, 4 Jun 2024 13:34:16 -0400
Subject: [PATCH] Fix Failing Dailies (#340)

* passed along secrets to update-testing-data

* added secrets to workflow_call section of update-testing-data

* fixed indentation

* added run-tests secrets

* added secrets to deploy_pr_tests

* updated changelog
---
 .github/workflows/dailies.yaml            | 6 ++++++
 .github/workflows/deploy_pr_tests.yaml    | 6 ++++++
 .github/workflows/run-tests.yml           | 3 +++
 .github/workflows/update-testing-data.yml | 7 +++++++
 CHANGELOG.md                              | 2 +-
 5 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/dailies.yaml b/.github/workflows/dailies.yaml
index 80c43f48..ce59bf38 100644
--- a/.github/workflows/dailies.yaml
+++ b/.github/workflows/dailies.yaml
@@ -8,10 +8,16 @@ on:
 jobs:
     update-testing-data:
         uses: ./.github/workflows/update-testing-data.yml
+        secrets:
+            AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+            AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+            S3_GIN_BUCKET: ${{ secrets.S3_GIN_BUCKET }}
 
     run-tests:
         needs: update-testing-data
         uses: ./.github/workflows/run-tests.yml
+        secrets:
+            CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
 
     notify:
         runs-on: ubuntu-latest
diff --git a/.github/workflows/deploy_pr_tests.yaml b/.github/workflows/deploy_pr_tests.yaml
index 58c040c1..7032304e 100644
--- a/.github/workflows/deploy_pr_tests.yaml
+++ b/.github/workflows/deploy_pr_tests.yaml
@@ -11,10 +11,16 @@ concurrency:
 jobs:
     update-testing-data:
         uses: ./.github/workflows/update-testing-data.yml
+        secrets:
+            AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+            AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+            S3_GIN_BUCKET: ${{ secrets.S3_GIN_BUCKET }}
 
     run-tests:
         needs: update-testing-data
         uses: ./.github/workflows/run-tests.yml
+        secrets:
+            CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
 
     dev-tests:
         needs: update-testing-data
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index ab173ca5..4c89b32c 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -2,6 +2,9 @@ name: Full Tests
 on:
   workflow_dispatch:
   workflow_call:
+    secrets:
+      CODECOV_TOKEN:
+        required: true
 
 jobs:
   run:
diff --git a/.github/workflows/update-testing-data.yml b/.github/workflows/update-testing-data.yml
index cbf342cc..b71c30c3 100644
--- a/.github/workflows/update-testing-data.yml
+++ b/.github/workflows/update-testing-data.yml
@@ -2,6 +2,13 @@ name: update-testing-data
 on:
   workflow_dispatch:
   workflow_call:
+    secrets:
+      AWS_ACCESS_KEY_ID:
+        required: true
+      AWS_SECRET_ACCESS_KEY:
+        required: true
+      S3_GIN_BUCKET:
+        required: true
 
 jobs:
   run:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index ad9780b8..7d488289 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -15,7 +15,7 @@
 * Remove unnecessary `scipy` import error handling: [#315](https://github.com/catalystneuro/roiextractors/pull/315)
 * Fixed the typing returned by the `InscopixImagingExtractor.get_dtype` method: [#326](https://github.com/catalystneuro/roiextractors/pull/326)
 * Detect Changelog Updates was moved to its own dedicated workflow to avoid daily testing failures: [#336](https://github.com/catalystneuro/roiextractors/pull/336)
-* Fixed the Update Testing Data Workflow by unpinning the version of awscli: [#339](https://github.com/catalystneuro/roiextractors/pull/339)
+* Fixed the Daily testing workflows by passing along the appropriate secrets: [#340](https://github.com/catalystneuro/roiextractors/pull/340)
 
 ### Improvements