Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all notifications into renderer process from main process #113

Open
cassidoo opened this issue Jan 17, 2023 · 3 comments
Open

Move all notifications into renderer process from main process #113

cassidoo opened this issue Jan 17, 2023 · 3 comments
Labels
good first issue Pull requests for folks new to the project

Comments

@cassidoo
Copy link
Owner

Right now notifications are spread between the main and renderer processes.

They should all be moved to the renderer process, so we can add custom sounds for them, and control messages from the main process better.
@cassidoo cassidoo added the good first issue Pull requests for folks new to the project label Jan 17, 2023
@ApurvaBasule
Copy link

@cassidoo can i work on this issue?

@cassidoo
Copy link
Owner Author

cassidoo commented Apr 14, 2023 •
edited
Loading

@ApurvaBasule sure thing, go for it!
I admit I started it and didn't get far because of some other responsibilities coming up, so I'd love to see your approach and maybe some of my code can be merged with yours, hahaha.

@cassidoo
Copy link
Owner Author

cassidoo commented Jun 5, 2023

@ApurvaBasule any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Pull requests for folks new to the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cassidoo @ApurvaBasule