-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for render mode SHRINK for AccessibilityRenderExtension #1355
base: master
Are you sure you want to change the base?
Conversation
39280d0
to
118bcf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious: why move from the unit test to the plugin test? It'd be nice keeping the former, unless there's a good reason.
Basically, the commit prior: https://github.com/cashapp/paparazzi/compare/c3e10703ecd6daab2a6f30e8118c511680437481..39280d0a467518e4b36799cfc25ec6c8ea16ad19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, got a comment in slack about moving it. I reverted that change to make the change smaller and straight forward
118bcf2
to
c3e1070
Compare
c3e1070
to
a8f28bd
Compare
import java.io.File | ||
import javax.imageio.ImageIO | ||
|
||
class AccessibilityRenderExtensionShrinkTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we combine this with AccessibilityRenderExtensionTest
+ TestParameterInjector? Looks like renderingMode
is the only argument that differs between the two.
Fixes #1350