Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4.0 was a breaking change #340

Closed
BatmanAoD opened this issue Sep 9, 2024 · 3 comments
Closed

2.4.0 was a breaking change #340

BatmanAoD opened this issue Sep 9, 2024 · 3 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@BatmanAoD
Copy link

The add_function signature changed, which breaks builds relying on this crate.

@casbin-bot casbin-bot added the question Further information is requested label Sep 9, 2024
@MuZhou233
Copy link
Contributor

The old signature is inconsist with document and blocks implemeting of key_get function. See #338
I don't have a way to not change the API. Do you have some idea?

@BatmanAoD
Copy link
Author

BatmanAoD commented Sep 19, 2024

@MuZhou233 I understand that the new API is necessary for certain features, but to avoid breaking people's builds unnecessarily, I think it would have been preferable to bump the version up to 3.0.

@hsluoyz
Copy link
Member

hsluoyz commented Sep 19, 2024

@BatmanAoD this is a small feature and not many people are using it. So we will not trigger a major release for it.

@hsluoyz hsluoyz closed this as completed Sep 19, 2024
@hsluoyz hsluoyz added wontfix This will not be worked on and removed question Further information is requested labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants