Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove "syntax validate" button, add toast message to run button #170

Merged
merged 8 commits into from
Nov 29, 2024
Merged

feat: remove "syntax validate" button, add toast message to run button #170

merged 8 commits into from
Nov 29, 2024

Conversation

HashCookie
Copy link
Contributor

@HashCookie HashCookie commented Nov 27, 2024 •
edited by hsluoyz
Loading

Fix: #160

UI feedback optimization

  • Success message (green)
  • Error Message (Red)
  • Loading/In Progress Message (Orange)

Function optimization

  • Add a protection mechanism against repeated clicks for the verification and run buttons (within 2 seconds).

@netlify Netlify
Copy link

netlify bot commented Nov 27, 2024 •
edited
Loading

✅ Deploy Preview for casbin-editor ready!

Name Link
🔨 Latest commit bd99c65
🔍 Latest deploy log https://app.netlify.com/sites/casbin-editor/deploys/6748adf564b062000829d69d
😎 Deploy Preview https://deploy-preview-170--casbin-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HashCookie
Copy link
Contributor Author

By the way:57da8c9

Fix grammar validation issues on first load

Description:

image
The message "missing required sections......." will briefly flash in the red box when loading the homepage.

Reason:

When the editor first loads, syntax validation is performed before the content (model and policy) has fully loaded.

Resolve:

  1. Add isContentLoaded state to track the content loading status.
  2. Optimize the content loading check logic to ensure that both modelKind and modelText are loaded.

@hsluoyz hsluoyz changed the title feat: optimize UI feedback and prevent duplicate submission mechanism. feat: remove "syntax validate" button, add toast message to run button Nov 29, 2024
@hsluoyz hsluoyz merged commit 8f3bca4 into casbin:master Nov 29, 2024
10 checks passed
@hsluoyz
Copy link
Member

hsluoyz commented Nov 29, 2024

🎉 This PR is included in version 1.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The three buttons should have more obvious effects for the output
2 participants
@HashCookie @hsluoyz