Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor comments from Carpentries Lab review #449

Closed
2 tasks done
svenvanderburg opened this issue Apr 23, 2024 · 1 comment · Fixed by #496
Closed
2 tasks done

Fix minor comments from Carpentries Lab review #449

svenvanderburg opened this issue Apr 23, 2024 · 1 comment · Fixed by #496
Assignees

Comments

@svenvanderburg
Copy link
Collaborator

svenvanderburg commented Apr 23, 2024

Look at carpentries-lab/reviews#25, see if there are any minor comments that we missed and can still improve.

Tasks

@carschno
Copy link
Collaborator

carschno commented Jul 22, 2024

Extracting the specific items from carpentries-lab/reviews#25 (comment) that are still open:

  • listed browser support is not matched to jupyter browser support notably, Windows' current default browser is a chromium browser and therefore supported (and on general web compatibility, better than safari by a nontrivial margin) this should be updated to include more windows users without having to install
  • all episodes are 55min + episode 3 is over 3 hours long? Addressed in Deal with long episodes #455
  • a glossary of key terms or links out to definitions in an external glossary e.g. Glosario.
  • Setup: it says "open a terminal" but that is insufficient information for a Windows user (they have multiple terminals and to launch jupyter only the "anaconda prompt" by default will work; CMD or powershell typically will not) (already resolved)

@carschno carschno self-assigned this Jul 22, 2024
@carschno carschno linked a pull request Jul 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants