Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other log items #7

Open
Morganamilo opened this issue Apr 4, 2018 · 6 comments
Open

Support other log items #7

Morganamilo opened this issue Apr 4, 2018 · 6 comments
Labels
enhancement New feature or request

Comments

@Morganamilo
Copy link
Contributor

Would be nice if this program could support other actions such as commands ran and scriptlets ran. These don't fit into the table though so maybe these would go into a different view?

If this is implemented it would also be nice to filter by [PACMAN] [ALPM] and [ALPM-SCRIPTLET].

@carlocastoldi
Copy link
Owner

Parsing [PACMAN] and [ALPM-SCRIPTLET] logs with scala-parser-combinator isn't a problem. I can do it with a lot of code to add. The problem is, as you said, to show everything in a organised way. If you have any idea just hit me up. In the meantime i can try to start a feature branch with a better parser with a better interface, if you wish

@carlocastoldi carlocastoldi added the enhancement New feature or request label Apr 4, 2018
@Morganamilo
Copy link
Contributor Author

Looking at the log file maybe you could organise everything into transactions? Group everything between transaction started and transaction complete

@carlocastoldi
Copy link
Owner

carlocastoldi commented Apr 4, 2018

I don't know... for the moment i'm a bit sceptical about it. I can't really see what kind of help this feature would add :/

@Morganamilo
Copy link
Contributor Author

I was thinking have a separate view for transactions that would show each transaction, you could either go to that view and look through all the transactions or hit enter on a package on the main view and it would take you to that transaction.

I get it's a lot of work, just a suggestion.

P.S. Nice job on tagging a realise. I made the aur package get the version through that and added a non -git AUR too https://aur.archlinux.org/packages/pacmanlogger/.

@carlocastoldi
Copy link
Owner

I'll certainly think about it. First off i want to finish with ALPM logs tho (i just pushed a release that introduced a SortBy menu. Now there are a few more feature i want to implement)

P.S. Yeah i guess that's that best way to organise things! Thanks for "forcing" me to do that, i need to learn it :)
On a side note: today a friend of mine suggested me to let you know to change the PKGBUILD to support future scala versions (at line 28, i think) & to change something to make the .sh run in a more protected environment (sorry, but i don't really remember what exactly he suggested me to change). Dunno how important it is but i guess it was good to let you know since you're far more experienced then me in these things

@Morganamilo
Copy link
Contributor Author

Heh I'm not forcing you, I would do it myself but after seeing scala for the first time with my PRs here god I hate it, there's no way I could handle a big change like that.

When it comes to your friend, about building for any version he probably just means use * instead of hard coding the version in the package function. I don't know whats wrong with java -jar though or how it's insecure.

You'r friend is free to leave a comment on the AUR page or send a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants