Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: CTRL+F Find instead of filter #52

Open
acastruc opened this issue Oct 5, 2024 · 2 comments
Open

Enhancement: CTRL+F Find instead of filter #52

acastruc opened this issue Oct 5, 2024 · 2 comments
Assignees

Comments

@acastruc
Copy link
Contributor

acastruc commented Oct 5, 2024

I load a log file and I am looking for occurrences of a substring, let's say 'foo'.
I hit ctrl+f and it takes me to the text filter field. I type 'foo' and only logs with 'foo' in it are displayed.
I believe this to be as designed.
I am wondering if there would be a way to do a standard 'find', where all instances of 'foo' are highlighted and hitting ENTER jumps between them but keeping all the logs visible ? This is often preferred over filtering because you often need to see the log lines surrounding the logs with 'foo'
Yes I understand a workaround is to filter them, mark them, then renable all logs and then jump between the marked logs, but this is extra steps and not as fluid.
Maybe a toggle switch to change filter field between filter+find? Or just add a separate "Find" feature doesnt hide all non-matches? I think filter and find are both useful and I'm not advocating to remove filter...just to add a find feature too.
Here's what I mean by standard "Find" - look what macOS console does
image

@acastruc acastruc changed the title CTRL+F Find instead of filter Enhancement: CTRL+F Find instead of filter Oct 5, 2024
@acastruc
Copy link
Contributor Author

acastruc commented Nov 1, 2024

@hamster620 any thoughts on the possibility of this?

@hamster620
Copy link
Collaborator

@hamster620 any thoughts on the possibility of this?

We still have some concerns about the suggestion on both UX and technical issues. Need more time to investigate and may not implement it in near major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants