Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for existing _FillValue in encoding #114

Open
maxrjones opened this issue Mar 19, 2024 · 0 comments
Open

Add test for existing _FillValue in encoding #114

maxrjones opened this issue Mar 19, 2024 · 0 comments

Comments

@maxrjones
Copy link
Contributor

In order to ensure compliance with the JSON spec and readability by zarr-js, we clear existing encodings in the datatree and set the _FillValue for each variable using the set_zarr_encoding utility function. While this is generally good, I am concerned that this could lead to the misinterpretation of data if the dataset already had a different no data value set via _FillValue and mask_and_scale was not used when loading the dataset. It seems worthwhile to add a test for that case.

@maxrjones maxrjones changed the title Add additional test for existing _FillValue in encoding Add test for existing _FillValue in encoding Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant