-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1-d infill error estimate #10
Comments
I'll take a look. 1-d arrays weren't really tested during development. I need to add some checks to make sure that the array is at least 2-d. The p factor is optimised in this code. Could you post a quick script to recreate the issue you're seeing with x*sin(x)? |
I've noticed something similar in working with 1-d arrays - please see the code below and resultant output.
Any assistance would be greatly appreciated. |
Hi, thanks for the example. I'm looking into this now. It seems to be an error in how the predictions are generated. More to come soon. Best, |
Did you ever figure out what was going on with this? |
Hi @capaulson , just wondering if you ever determined the cause of the issue here. Thanks! |
I think there might be a bug in the kriging or MSE estimate if the problem is compressed to 2-D (ie, one input and one output). If you run the x*sin(x) test function with only a few points (2-4) and plot the error estimate, it doesn't look correct.
Is the smoothness factor "p" getting optimized on as well as the theta values? If not, that might cause this issue. I believe this bug also exists in the Matlab code, so that won't be a great resource to compare against.
The text was updated successfully, but these errors were encountered: