Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import splits multiline history entries as multiple commands #432

Open
iloveitaly opened this issue Jul 29, 2024 · 1 comment
Open

Import splits multiline history entries as multiple commands #432

iloveitaly opened this issue Jul 29, 2024 · 1 comment

Comments

@iloveitaly
Copy link

This is documented here but it would be great if there was an option to either (a) omit multiline commands or (b) properly handle them. I may have some time to help with this; mind pointing me in the right direction?

@cantino
Copy link
Owner

cantino commented Aug 12, 2024

Thanks @iloveitaly, and sorry for the delay. There are probably a few places this needs to be handled:

  1. When importing existing history, which means updating the history file parsers in https://github.com/cantino/mcfly/blob/master/src/shell_history.rs
  2. When adding a new command to the DB (in mcfly.fish as '$argv[1]' for fish, handled in https://github.com/cantino/mcfly/blob/master/src/settings.rs#L344C40-L347C22 for bash and zsh, and possibly not parsing right until 1 is done above)
  3. Displaying in the UI
  4. Outputting commands back to the terminal https://github.com/cantino/mcfly/blob/master/src/main.rs#L48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants