build(snap): update snap to core24 #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigarmo
force-pushed
the
work/CRAFT-3677-rockcraft-core24
branch
from
32b4d5a to
61bb971
Compare
dariuszd21
approved these changes
Dec 3, 2024
We're not currently updating the changelog with individual PRs in rockcraft. I want to start doing that next year (maybe) but for now the changelog is a separate task pre-release. |
mr-cal
reviewed
Dec 5, 2024
sergiusens
reviewed
Dec 5, 2024
tigarmo
force-pushed
the
work/CRAFT-3677-rockcraft-core24
branch
2 times, most recently
from
8ff40ec to
6030895
Compare
sergiusens
approved these changes
Dec 6, 2024
sergiusens
reviewed
Dec 6, 2024
This bumps the default Python version on CI to 3.12, which corresponds to the version of the snap itself.
The package is gone in Python 3.12. This affects unused code, which is now gone, and some spread tests. The spread tests are still valid because they use older bases, so just add a pyright exclusion for them.
tigarmo
force-pushed
the
work/CRAFT-3677-rockcraft-core24
branch
from
6030895 to
3f78479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #750