Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSHFS watchdog doesn't notice thread exit #3745

Open
Sploder12 opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3735
Open

SSHFS watchdog doesn't notice thread exit #3745

Sploder12 opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3735
Labels

Comments

@Sploder12
Copy link
Contributor

Describe the bug
The SSHFS server's watchdog doesn't have a way of verifying that the SFTP thread it watches is still alive. This causes the SSHFS server process to continue executing even if it is no longer functional. This causes mounted folders to hang the shell since the SSH session is still alive but SFTP is not.

To Reproduce

  1. Create a SSHFS mount.
  2. Cause SftpServer::run to exit by some means.
  3. Observe the SSHFS server process running with no errors logged and not functional.

Expected behavior
The SSHFS watchdog notices the thread exit and takes appropriate actions so that there are logs and the shell doesn't hang.

@Sploder12 Sploder12 added bug needs triage Issue needs to be triaged labels Oct 18, 2024
@Sploder12 Sploder12 linked a pull request Oct 18, 2024 that will close this issue
@ricab ricab removed the needs triage Issue needs to be triaged label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants