Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install multiple postgis version in the same docker image #9

Open
tcoupin opened this issue Nov 4, 2017 · 1 comment
Open

Comments

@tcoupin
Copy link
Contributor

tcoupin commented Nov 4, 2017

Docker image should be as small as possible so one version of postgresql and one version of postgis.

Having multiple version is useful for integration tests against multiple environments.
For names, just follow officials images tag rules:

  • latest, 10, 10.0, 10-pgis2.4, 10.0-pgis2.4, pgis2.4
  • 9, 9.6, 9-pgis2.4, 9.6-pgis2.4
  • 9-pgis2.3, 9.6-pgis2.3
  • 9-pgis2.2, 9.6-pgis2.2
  • ...

Multiple ways to achieve that:

  • use the automated builds of hub.docker.com
    • 👍
      • already setup for your repo
      • use the "repository link" feature to rebuild postgis image on new official postgres image
    • 👎
      • configuration tag by tag, one dockerfile by (psql_version, pgis_version)
  • use other CI platform like travis-ci.org
    • 👍
      • one dockerfile used with build-arg
      • just list matrix of (psql_version, pgis_version)
      • multi-arch build are possible (arm... )
    • 👎
      • no "repository link"
@mcanevet
Copy link
Contributor

I'm not sure the gain in space worth the complexity added.
Moreover I think our dev sometimes want multiple versions of PostGis installed in the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants