-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FUSETOOLS2-2302: Allow to link utils package during Main build of Camel tooling projects #1664
base: main
Are you sure you want to change the base?
Conversation
47f3a39
to
4e929bc
Compare
a6e5a9a
to
511e128
Compare
511e128
to
baf7a49
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure to understand what is happening.
In case, we need to provide modifications to vscode-uitests-tooling then we can use it without modification. For that it checks if there is a branch with the same name than the current build of camel-lsp-client-vscode?
We want to move as much as possible to utils package instead of having functions in individual components as these functions are very often used in more than one component. If you want to make changes in utils package as well, you need branch with same name as branch in camel-lsp-client-vscode. If there's no branch with same nebo or fork of utils repo at all, flow will be acting like until now. If there's branch with same name, build of this branch will be used for testing PR flow. In a summary, if I add function A to utils branch and call it inside some PR here, on camel-lsp-client-vscode, it will pass. It's necessary to publish utils package first. If not, after merge on camel-lsp-client-vscode will main pipeline fail. |
that's a key point. Thanks for the clarification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, wait for follow up tasks before merge of this one
Pull Request informations
Rebase & Merge default requirements
PR labels default process
Tests
PR workflow progress