Clarifications about optional parameters #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PedroDiez
requested review from
ToshiWakayama-KDDI and
bigludo7
as code owners
bigludo7
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
I'm fine with this update.
@PedroDiez Don't you think this is something that should be also raised at commonalities level? I'm a bit mixed on this topic --> We should avoid as much as possible specialization but I perfectly understand that we have real case where we cannot avoid it.
|
Checked with RM and there is no deadline for a patch release |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Add a clarification about optional parameters in the Carrier Billing APIs
Which issue(s) this PR fixes:
Fixes #179
Special notes for reviewers:
Do we generate patch release with this?
Changelog input
Additional documentation
N/A