Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle teams #13

Open
21echoes opened this issue Oct 7, 2020 · 0 comments
Open

Handle teams #13

21echoes opened this issue Oct 7, 2020 · 0 comments

Comments

@21echoes
Copy link
Contributor

21echoes commented Oct 7, 2020

References to teams (e.g., assigning a team as a reviewer) should use the GitHub API to convert that team into a list of individuals, and then we should perform the usual behavior (e.g., DM notification) for each of them. Notifications failing for one team member should not short-circuit and prevent other notifications from going out.

By default, the token we are given (the secrets.GITHUB_TOKEN env var) does not seem to have the requisite permissions to fetch teammates: https://docs.github.com/en/free-pro-team@latest/actions/reference/authentication-in-a-workflow#permissions-for-the-github_token so we'll either need to:

  • find a different way to get the list of users directly from the existing payload? it's a huge payload, maybe it's hidden in there somewhere 🕵️
  • every repo which wants to use this action will need to provide their own custom token with the requisite permisisons 😢
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant