-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing Button Mode doesn't work dynamically (Expo 52) #4559
Comments
Are you using a new architecture? It seems the issue is in Expo or on the React Native side not the react native paper side problem. |
Yes, new architecture. |
I just updated app.json's newArchEnabled:false and I still see the issue. |
Potentially related to #4520. I've also added this to the list of new arch affected issues for visibility. |
I can confirm with @dbrownstatsdraft . I am seeing the issue with "newArchEnabled: false" and "newArchEnabled: true" on expo 52.0.11 |
following as I'm having the same issue with new expo projects |
Expo ~52.0.9. Same issue here. Button doesn't get rendered at all when its properties change. I have to force rendering it by changing 'key' attribute as a workaround. "newArchEnabled: false" and "newArchEnabled: true" don't make any difference. |
Current behaviour
After upgrading to Expo 52 I can no longer change a button's mode attribute dynamically in iOS 18.1 simulator. Either programmatically or manually while developing. I must restart the app for the change to take effect when changing manually. It also appears that all styles are effected in this same way. If I update a style like margin it doesn't take effect until I either kill and restart the app or send a refresh signal via expo.
Expected behaviour
I should be able to change a Button's mode from "text" to "contained" and see the changes immediately in the app.
How to reproduce?
Create a new expo 52 app.
Create a react-native-paper (latest) button
Set button mode to "text"
Run in iOS 18.1 simulator
Change button mode to "contained" and save file
Look at button now. It will be in an in between state
Snack Link
Ensure Expo 52 and iOS or Android. Seems to work fine on Web but not iOS or Android.
Preview
Top button mode set to contained.
After button press top button mode is set to text but wrapping container still has the fill color
What have you tried so far?
Confirmed that downgrading expo to 51 works.
Your Environment
The text was updated successfully, but these errors were encountered: