Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[newarch][android] portal now flickers when onDismiss #4555

Open
lovegaoshi opened this issue Nov 14, 2024 · 2 comments
Open

[newarch][android] portal now flickers when onDismiss #4555

lovegaoshi opened this issue Nov 14, 2024 · 2 comments
Labels

Comments

@lovegaoshi
Copy link

Current behaviour

Hi! I've noticed the portal element now may flicker when its exited via onDismiss, under the new arch. its fine when exited via onClose. its fine with the old arch.

Expected behaviour

portaled component does not flicker

How to reproduce?

https://snack.expo.dev/@react-native-paper/more-examples---comprehensive-portal-example with expo 52

Preview

N/A

What have you tried so far?

I have deduced its visibleRef.current is still true when at the end of onDismiss, so its shown again. so I removed it and it seems to work normally now

Your Environment

software version
ios N/A
android 14
react-native 0.76.2
react-native-paper 5.12.5
node 20
npm or yarn 4
expo sdk 52
@arasrezaei
Copy link

same here, there is flicker for menu, dialog components on dismiss

@codan84
Copy link

codan84 commented Dec 19, 2024

Not only it flickers on onDismiss, but even worse: any TextInput will flicker when changing text if it is within portal. I reproduced it here, shows both issues:
https://github.com/codan84/text-input-flicker
+ it does it on iOS too, so not only Android issue this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants