Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing aria properties #133

Open
rcbyron opened this issue Jul 26, 2024 · 4 comments
Open

Missing aria properties #133

rcbyron opened this issue Jul 26, 2024 · 4 comments

Comments

@rcbyron
Copy link

rcbyron commented Jul 26, 2024

Receiving the following typescript error in my Angular app:

Error: node_modules/.pnpm/[email protected]/node_modules/element-internals-polyfill/dist/element-internals.d.ts:4:22 - error TS2420: Class 'ElementInternals' incorrectly implements interface 'IElementInternals'.
  Type 'ElementInternals' is missing the following properties from type 'IElementInternals': ariaBrailleLabel, ariaBrailleRoleDescription

4 export declare class ElementInternals implements IElementInternals {
                       ~~~~~~~~~~~~~~~~

@rcbyron
Copy link
Author

rcbyron commented Jul 26, 2024

Downgrading Typescript from 5.5.4 to 5.4.5 fixed the issue for now

@calebdwilliams
Copy link
Owner

I have a version of this in progress on the fix-ts branch if you want to look at it to see if it fixes your issues. I'm working through how best to test this right now.

@abeggchr
Copy link

abeggchr commented Dec 9, 2024

Same issue here. In the meantime, there are two open PRs #134 and #135. Any chance this issue can be resolved?

@calebdwilliams
Copy link
Owner

calebdwilliams commented Dec 11, 2024

Those PRs don’t actually fix the issue. If I could get feedback on the branch from the previous post I’ll merge and release that bi just don’t want to break anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants