Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Dirty state after tests #903

Open
dereuromark opened this issue Jan 10, 2023 · 3 comments
Open

2.x: Dirty state after tests #903

dereuromark opened this issue Jan 10, 2023 · 3 comments

Comments

@dereuromark
Copy link
Member

Description

git status:

        tests/test_app/App/Controller/ArticlesController.php
        tests/test_app/App/Controller/ArticlesTagsController.php
        tests/test_app/App/Controller/BakeArticlesBakeTagsController.php
        tests/test_app/App/Controller/BakeAuthorsController.php
        tests/test_app/App/Controller/BakeTagsController.php
        tests/test_app/App/Controller/BinaryTestsController.php
        tests/test_app/App/Controller/CarController.php
        tests/test_app/App/Controller/CategoriesController.php
        tests/test_app/App/Controller/CategoriesProductsController.php
        tests/test_app/App/Controller/CategoryThreadsController.php
        tests/test_app/App/Controller/DatatypesController.php
        tests/test_app/App/Controller/HiddenFieldsController.php
        tests/test_app/App/Controller/InvitationsController.php
        tests/test_app/App/Controller/NumberTreesController.php
        tests/test_app/App/Controller/OldProductsController.php
        tests/test_app/App/Controller/ProfilesController.php
        tests/test_app/App/Controller/RolesController.php
        tests/test_app/App/Controller/SelfReferencingUniqueKeysController.php
        tests/test_app/App/Controller/TagsController.php
        tests/test_app/App/Controller/TodoItemsController.php
        tests/test_app/App/Controller/TodoItemsTodoLabelsController.php
        tests/test_app/App/Controller/TodoLabelsController.php
        tests/test_app/App/Controller/TodoRemindersController.php
        tests/test_app/App/Controller/TodoTasksController.php
        tests/test_app/App/Controller/UniqueFieldsController.php
        tests/test_app/App/Controller/UsersController.php

Those files are not in gitignore, other files similar are commited already
But if you do, it will fail in consecutive run, as there is also no proper cleanup

IMO, the bake tests should create those in a tmp dir and not along the actual commited files.

Bake Version

2.x

PHP Version

8.1

@dereuromark dereuromark added this to the 2.x (CakePHP 4) milestone Jan 10, 2023
@othercorey
Copy link
Member

Baking the files into the test_app directory is really annoying since sometimes they aren't wiped out on a failure.

@dereuromark
Copy link
Member Author

Should we look into using vfsStream and memory file system instead of real one?

@github-actions
Copy link

github-actions bot commented Jul 9, 2023

This issue is stale because it has been open for 120 days with no activity. Remove the stale label or comment or this will be closed in 15 days

@github-actions github-actions bot added the stale label Jul 9, 2023
@othercorey othercorey added pinned and removed stale labels Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants