Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CW-829 Solana Enhancements #1858

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

Blazebrain
Copy link
Contributor

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods

@Blazebrain Blazebrain self-assigned this Dec 5, 2024
@Blazebrain Blazebrain changed the title feat: Solana enhancements with rent handling for accounts CW-829 Solana Enhancements Dec 9, 2024
Copy link
Contributor

@OmarHatem28 OmarHatem28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all the errors caught correctly?
also, please throw an exception class and handle the message in the send_view_model as we do for electrum wallets, so that they are translated

@Blazebrain
Copy link
Contributor Author

are all the errors caught correctly? also, please throw an exception class and handle the message in the send_view_model as we do for electrum wallets, so that they are translated

Yes, they are all being caught correctly. It displays the right error to the user.

We can do the exception classes also, makes for more clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants