-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTEL_EXPORTER_OTLP_PROTOCOL env variable support #5743
Comments
PRs welcome. Most maintainers don't use tracing or metrics ourselves, so we need to lean on the community to contribute improvements. |
I think this may be the reason Caddy doesn't work with grafana since they only expose the HTTPS port |
Can you elaborate? In what way does Caddy "not work with grafana"? |
When you create a free stack at grafana.com and try to set up their OTEL collector it recommends the following environment variables
I also added
So problems with Caddy are
|
Maybe it's the way I am testing RUN git clone https://github.com/trajano/caddy /mnt/
RUN xcaddy build \
--replace github.com/caddyserver/caddy/v2/modules/caddyhttp/tracing=/mnt/modules/caddyhttp/tracing
FROM caddy
COPY --from=builder /usr/bin/caddy /usr/bin/caddy |
Figured out what was wrong with the Dockerfile Got a bit further but got
But posting directly using curl seems to work |
Finally got it working, the last bit was a typo might've accidentally transposed two characters in the |
I can't merge #6487 until master builds cleanly.
[https://opengraph.githubassets.com/2a261bf798dd7b9f98bb5d496a4efcb97869d4da56424bb702b2c377132fad69/caddyserver/caddy/pull/6487]<https://github.com/caddyserver/caddy/pull/6487>
Add Otel Trace client interactions by trajano · Pull Request #6487 · caddyserver/caddy<#6487>
Should be okay now for the most part it works well see trajano/google-fonts-proxy-docker#7 (comment) for a screenshot But there's one context.TODO() line I am not sure which context to pass in ...
github.com
…________________________________
From: 'core2duoe6420' via Open Source Development ***@***.***>
Sent: Tuesday, August 27, 2024 9:29 AM
To: caddyserver/caddy ***@***.***>
Cc: Archimedes Trajano ***@***.***>; Mention ***@***.***>
Subject: Re: [caddyserver/caddy] Add OTEL_EXPORTER_OTLP_PROTOCOL env variable support (Issue #5743)
@trajano<https://github.com/trajano> Do you have plan to raise a pull request to merge your change? I believe the way you are doing is the canonical way to instrument tracer and exporters.
—
Reply to this email directly, view it on GitHub<#5743 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAA3AI4O3JOHTNGI4X2DVPLZTR5K7AVCNFSM6AAAAABLSTTJMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJSGU3DOMRYGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
In the opentelemetry documentation you have link to, there is a configuration of the protocol for traces to send: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.7.0/specification/protocol/exporter.md#specify-protocol. It can be
grpc
orhttp/protobuf
etc.As far as I see in the code: https://github.com/caddyserver/caddy/blob/master/modules/caddyhttp/tracing/tracer.go#L61 you have only
grpc
supported.It would be great to have other options like
http/protobuf
supported as well. Some tracing ingesters have the no GRPC support by different reasons.The text was updated successfully, but these errors were encountered: