Fix hashmap put all for create + test case #1696
Open
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerno
reviewed
Dec 18, 2024
lib/std/collections/hashmap.c3
Outdated
| @@ -455,8 +455,10 @@ fn void HashMap.put_all_for_create(&map, HashMap* other_map) @private | |||
| if (!other_map.count) return; | |||
| foreach (Entry *e : other_map.table) | |||
| { | |||
| if (!e) continue; | |||
| map.put_for_create(e.key, e.value); | |||
| while (e) { | |||
There was a problem hiding this comment.
Can you fix it to match the other coding style, so Allman braces?
|
Can you also add mention in the release notes? |
|
And the same bug is presumably in map.c3 as well, can you fix it? |
tomaskallup
force-pushed
the
fix-hashmap-put-all-for-create
branch
from
b809bcb to
15af01c
Compare
|
Fixed it up, I'll try to also add unit tests for the regular |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I based these changes on the implementation of
@each, which does an innerwhileloop, checking forentry.next.Closes: #1695