Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Aframe 1.5.0 compatible (remove conflicts with new core component grabbable) #238

Open
Plarixtu opened this issue Jan 3, 2024 · 10 comments

Comments

@Plarixtu
Copy link

Plarixtu commented Jan 3, 2024

In Aframe 1.5.0 release there was a component added to core called "grabbable". This leads to conflicts with the component of super-hands, which has the same name.

@arpu
Copy link
Contributor

arpu commented Jan 10, 2024

maybe this should be changed in aframe?

@vincentfretin
Copy link
Member

I don't think @dmarcos will want to change the name, the component is included in an aframe release already.

I didn't test, but you should be able to use the following to resolve the issue:

<script src="https://aframe.io/releases/1.5.0/aframe.min.js"></script>
<script>
delete AFRAME.components["grabbable"];
</script>
<script src="https://unpkg.com/super-hands@^3.0.3/dist/super-hands.min.js"></script>

We probably need to rename grabbable to sh-grabbable in this repo to really fix the issue.

@jonarnaldo
Copy link

any updates on this? 🙏

@vincentfretin
Copy link
Member

@jonarnaldo Do the above code snippet works for you?

I'm not using this component, so I won't work it. But someone can make a PR if we agree on something here.
If we rename the grabbable component, we probably want to rename all components hoverable, clickable, grabbable, stretchable, draggable, and droppable.
What do you think @wmurphyrd?

@Utopiah
Copy link

Utopiah commented Mar 8, 2024

I'd also recommend sh-grabbable because SupreHands depends on AFrame, not the other way around. What's the functionality difference though? Are they exactly equivalent or not?

PS: I'd also appreciate @wmurphyrd's view on the topic as he's been thinking on this quite a bit.

@v5ma
Copy link

v5ma commented Apr 19, 2024

jeezus, it took me forever to eventually get to this page, after trying everything to fix my code.

@v5ma
Copy link

v5ma commented Apr 19, 2024

[vincentfretin's solution works 100% I just tested it. It should be at least AT LEAST added to the Super Hands documentation including on the read me underneath Installation, UNTIL we have a new name to replace grabbable, like graspable

<script src="https://aframe.io/releases/1.5.0/aframe.min.js"></script> <script> delete AFRAME.components["grabbable"]; </script> <script src="https://unpkg.com/super-hands@^3.0.3/dist/super-hands.min.js"></script>

@vincentfretin
Copy link
Member

PR welcome to add it to the README, thanks!

@v5ma
Copy link

v5ma commented Apr 25, 2024

It just occurred to me that someone could write a my-super-hands component also that somehow replaces the word grabbable with something else.

@jgbarah
Copy link
Contributor

jgbarah commented Apr 30, 2024

It seems the README is now updated, via #239.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants