You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
note: links aren't relative, so clicking https://diarmidmackenzie.github.io/aframe-physics-system and then clicking through to examples leads to the c-frame master examples instead of your local ones. may want to update those while you're here.
I don't know how to solve this. There's a good reason the links aren't relative - they wouldn't work in both the README view in GitHub and also on GitHub pages.
But if they are absolute, they need to updated every time you fork / merge. Which would quite likely lead to broken links in master (whic IMO is worse than broken links in a preview of a PR).
From #17
One other point worth commenting on:
I don't know how to solve this. There's a good reason the links aren't relative - they wouldn't work in both the README view in GitHub and also on GitHub pages.
But if they are absolute, they need to updated every time you fork / merge. Which would quite likely lead to broken links in master (whic IMO is worse than broken links in a preview of a PR).
The problem seems to be documented here:
https://stackoverflow.com/questions/40196198/automatic-link-to-github-pages-url-from-readme-md
It's possible that this GitHub Action could provide a solution. There don't seem to be any other solutions available.
https://github.com/marketplace/actions/dynamic-readme
Originally posted by @diarmidmackenzie in #17 (comment)
The text was updated successfully, but these errors were encountered: