Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetWasmTailCall #227

Open
bobappleyard opened this issue Aug 10, 2024 · 2 comments
Open

SetWasmTailCall #227

bobappleyard opened this issue Aug 10, 2024 · 2 comments

Comments

@bobappleyard
Copy link
Contributor

There is a configuration function in the wasmtime C API, in config.h: void wasmtime_config_wasm_tail_call_set(bool). This enables the tail call proposal, allowing modules containing return_call and return_call_indirect instructions to be executed.

I note that for many of the other functions in that header file, a method on *Config is provided.

Is there a particular reason why this function was left out, or am I OK to add a method for this configuration function to the struct?

@bobappleyard
Copy link
Contributor Author

One big reason is that it's already enabled by default 🤦

@alexcrichton
Copy link
Member

No reason to leave this out, only that it wasn't there when the bindings were first written. I think it would still make sense to add this as a method, even if it's on-by-default, so embedders can explicitly enable/disable if needed. If you'd like a PR would work well here!

@bobappleyard bobappleyard reopened this Dec 3, 2024
bobappleyard added a commit to bobappleyard/wasmtime-go that referenced this issue Dec 3, 2024
bobappleyard added a commit to bobappleyard/wasmtime-go that referenced this issue Dec 3, 2024
bobappleyard added a commit to bobappleyard/wasmtime-go that referenced this issue Dec 4, 2024
alexcrichton pushed a commit that referenced this issue Dec 4, 2024
* Add some missing configuration flags (#227)

* PR comments (#227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants