Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Oracle Autonomous Database driver #576

Closed
Maros112358 opened this issue Aug 29, 2024 · 3 comments
Closed

Include Oracle Autonomous Database driver #576

Maros112358 opened this issue Aug 29, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Maros112358
Copy link

Is your feature request related to a problem? Please describe.
We would like to use sql_exporter with Oracle Autonomous Database. According to the article Connecting a Go application to Oracle Database, the only thing required should be to add package go_ora to sql_exporter.

Describe the solution you'd like
Add go_ora to sql_exporter.

Describe alternatives you've considered
Compile the sql_exporter with go_ora ourselves.

@Maros112358 Maros112358 added the enhancement New feature or request label Aug 29, 2024
@burningalchemist
Copy link
Owner

burningalchemist commented Aug 29, 2024

Hi @Maros112358, we have a PR for that (#575). I'm still evaluating the necessity to include it by default as it would increase the size of the binary, and I want to keep the list small.

Besides, I consider removing drivers for proprietary databases from the default build, and just leave MySQL and PostgreSQL. If the database can be installed locally, then it'd be fine. With MSSQL you can install Express edition which is free. With Oracle I don't know if it's possible, but I haven't looked into it.

I believe it's simple enough to just add one string with a required driver, rebuild the app with two commands, and have it included. The documentation contains all the necessary steps.

Currently, you can just add the driver, and rebuild the software, and it will work just fine.

@Maros112358
Copy link
Author

Hello @burningalchemist, thank You for thorough elaboration.

Oracle Autonomous Database is available for free as a public docker image:

docker pull container-registry.oracle.com/database/adb-free:latest

Oracle Database is also available publicly https://www.oracle.com/database/free/get-started

We will rebuild the image for now, thank You.

@burningalchemist
Copy link
Owner

burningalchemist commented Aug 29, 2024

Hey @Maros112358, thanks for the information. I'll have a look and try it out. If the size increase is small enough, I might add it then. 👍

I'll close the issue as it's already described in the linked PR. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants